fix: prevent directory nodes from appearing as ghost tabs (#1182)#1874
Open
moaaz-ae wants to merge 1 commit intosveltejs:mainfrom
Open
fix: prevent directory nodes from appearing as ghost tabs (#1182)#1874moaaz-ae wants to merge 1 commit intosveltejs:mainfrom
moaaz-ae wants to merge 1 commit intosveltejs:mainfrom
Conversation
|
@moaaz-ae is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating or renaming files with nested paths (e.g.,
src/lib/Button.svelte) caused non-functional ghost tabs to appear for each directory segment, and broke the Download App feature by attempting to read.contentsfrom directory nodes. Fixed by adding afile_nodesgetter toWorkspacethat filters to onlyFileentries, and using it inComponentSelectorandRepl.toJSON()to prevent directories from surfacing in the UI or exports.Fixes #1182
Before
before.mp4
After
Screencast.From.2026-03-18.15-22-44.mp4